Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve save/load methods for encrypted data-frames #582

Merged
merged 3 commits into from
Apr 4, 2024
Merged

chore: improve save/load methods for encrypted data-frames #582

merged 3 commits into from
Apr 4, 2024

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft commented Apr 3, 2024 •
edited
Loading

this should make the save/load methods faster

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner April 3, 2024 14:36
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
andrei-stoian-zama
andrei-stoian-zama requested changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick PR. Can you clarify a few things please?

src/concrete/ml/pandas/_utils.py Show resolved Hide resolved
src/concrete/ml/pandas/dataframe.py Outdated Show resolved Hide resolved
@RomanBredehoft RomanBredehoft force-pushed the chore/improve_save_load_encrypted_dataframe branch from cedebba to 8cc956d Compare April 4, 2024 08:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7550      0   100%

59 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft merged commit c1f4b78 into main Apr 4, 2024
13 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/improve_save_load_encrypted_dataframe branch April 4, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei-stoian-zama andrei-stoian-zama andrei-stoian-zama approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanBredehoft @andrei-stoian-zama